Skip to content

server: make snapshotting on KVM non-blocking#3209

Merged
yadvr merged 2 commits intoapache:masterfrom
shapeblue:kvm-fix-snapshot-vr-ops
Mar 25, 2019
Merged

server: make snapshotting on KVM non-blocking#3209
yadvr merged 2 commits intoapache:masterfrom
shapeblue:kvm-fix-snapshot-vr-ops

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Mar 12, 2019

This references and uses an already fixed solution from
MissionCriticalCloud/cosmic#68 to make
snapshotting on KVM non-blocking.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@yadvr
server: make snapshotting on KVM non-blocking
5300f68 
This references and uses an already fixed solution from
MissionCriticalCloud/cosmic#68 to make
snapshotting on KVM non-blocking.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Mar 12, 2019
@yadvr
Copy link
Member Author

yadvr commented Mar 12, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr
move StorageSubSystemCommand instanceof check above as CopyCommand is…
1a15663 
… a type of StorageSubSystemCommand

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2625

@yadvr
Copy link
Member Author

yadvr commented Mar 12, 2019

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2626

@yadvr
Copy link
Member Author

yadvr commented Mar 12, 2019

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Mar 12, 2019

Trillian test result (tid-3417)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24373 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3209-t3417-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_enable_ha_when_host_in_maintenance Error 301.66 test_hostha_kvm.py

wido
wido approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 462a37d into apache:master Mar 25, 2019
pbankonier pushed a commit to pbankonier/cloudstack that referenced this pull request Apr 24, 2019
@yadvr
server: make snapshotting on KVM non-blocking (apache#3209)
4703df2 
* server: make snapshotting on KVM non-blocking

This references and uses an already fixed solution from
MissionCriticalCloud/cosmic#68 to make
snapshotting on KVM non-blocking.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* move StorageSubSystemCommand instanceof check above as CopyCommand is a type of StorageSubSystemCommand

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wido wido wido approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@remibergsma remibergsma Awaiting requested review from remibergsma

@nvazquez nvazquez Awaiting requested review from nvazquez

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @blueorangutan @wido @DaanHoogland